Skip to content

add getter as public api for ErrorUtils._globalHandler - #5575

Closed
qbig wants to merge 1 commit into
react:masterfrom
qbig:add-public-api-for-global-js-except-handler
Closed

qbig wants to merge 1 commit into
react:masterfrom
qbig:add-public-api-for-global-js-except-handler

Conversation

@qbig

@qbig qbig commented Jan 27, 2016

Copy link
Copy Markdown
Contributor

As discussed here #1194 . This add an getter the default handler, so that custom handler can be added (monkey patch?) without overwriting the default handler

@facebook-github-bot

Copy link
Copy Markdown
Contributor

By analyzing the blame information on this pull request, we identified @janicduplessis, @spicyj and @vjeux to be potential reviewers.

@facebook-github-bot facebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Jan 27, 2016
@facebook-github-bot

Copy link
Copy Markdown
Contributor

@qbig updated the pull request.

@corbt

corbt commented Feb 18, 2016

Copy link
Copy Markdown
Contributor

This seems useful.

@facebook-github-bot shipit

@facebook-github-bot

Copy link
Copy Markdown
Contributor

Thanks for importing. If you are an FB employee go to Phabricator to review.

@ghost ghost closed this in e0a0cac Feb 18, 2016
cpojer pushed a commit to react/metro that referenced this pull request Jan 26, 2017
Summary:As discussed here #1194 . This add an getter the default handler, so that custom handler can be added (monkey patch?) without overwriting the default handler
Closes react/react-native#5575

Differential Revision: D2948994

fb-gh-sync-id: 2b6d1619cfe68f78b326c6d232b9bf57c489c45d
shipit-source-id: 2b6d1619cfe68f78b326c6d232b9bf57c489c45d
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants